Include react-dom package #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of including react-dom in react-native-web, and moving the stylesheet management into the library (no longer responsibility of app developer). Other methods on react-dom could also be included much like React Native's environment-specific additions. Relates to #52
| // React | ||
| ...React | ||
| ...React, |
There was a problem hiding this comment.
could spread ReactDOM too, effectively returning to the 0.13 API since we're web-only
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of including react-dom in react-native-web, and moving the stylesheet management into the library (no longer responsibility of app developer). Other methods on react-dom could also be included much like React Native's environment-specific additions.
Relates to #52