Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gatsby integration #868

Closed
wants to merge 1 commit into from
Closed

Add Gatsby integration #868

wants to merge 1 commit into from

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Mar 18, 2018

No description provided.

necolas
necolas requested changes Mar 29, 2018
View reviewed changes
Copy link
Owner

@necolas necolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be added after the following happens:

  1. PR for AppRegisty is merged.
  2. Your plugin doesn't use getApplication in the browser.
  3. There is an official Gatsby example listed here, which is what RNW will link to.

@slorber
Copy link
Contributor Author

slorber commented Apr 7, 2018

I've made a Gatsby example PR: gatsbyjs/gatsby#4885

Waiting for 1) PR feedback or merge to tackle 2)

@necolas necolas closed this in 8442f13 Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slorber @necolas