Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#430 sg e8257 d #537

Merged
merged 9 commits into from
May 13, 2024
Merged

#430 sg e8257 d #537

merged 9 commits into from
May 13, 2024

Conversation

yamatomatsuzuki
Copy link
Contributor

Checks

  • Debugging completed
  • Please debug me

Related Issue

This PR closes #430

@yamatomatsuzuki yamatomatsuzuki self-assigned this May 10, 2024
@TatsumiISHIKAWA TatsumiISHIKAWA added the enhancement New feature or request label May 10, 2024
@TatsumiISHIKAWA TatsumiISHIKAWA added this to the Release v0.26.0 milestone May 10, 2024
Copy link
Contributor

@TatsumiISHIKAWA TatsumiISHIKAWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Pythonファイルになっていないので拡張子を変更してください。
  • 最新版からコード全体にかなりアップデートがあるのでMainの内容をMergeしておいてください。

@TatsumiISHIKAWA TatsumiISHIKAWA self-requested a review May 13, 2024 08:37
Copy link
Contributor

@TatsumiISHIKAWA TatsumiISHIKAWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TatsumiISHIKAWA TatsumiISHIKAWA added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit dc22764 May 13, 2024
4 checks passed
@TatsumiISHIKAWA TatsumiISHIKAWA deleted the #430-sgE8257D branch May 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Signal Generator:E8257D
2 participants