-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation error due to handle::clone using incomplete handle type (C++20) #214
Comments
You surprise me, as I use LLFIO in C++ 20. Which compiler and standard library? Exact versions please. |
MSVC 19.24.28314 and clang-cl/clang with a trunk build from last week (clang required fixing the __cpuid lambda in impl/windows/storage_profile.ipp by making the cpuInfo pointer non-const). Small repro: https://godbolt.org/z/38ijAH My cmake options are, among others:
|
…e early check for destructibility of `T` and `E`, so removed template constraints, falling back to static assert which runs later in the type instantiation sequence.
Ok, should be fixed now. If your LLFIO is using Outcome via superbuild into your build directory, you will need to remove the outcome subdirectory within your build directory, and rerun cmake. |
…e early check for destructibility of `T` and `E`, so removed template constraints, falling back to static assert which runs later in the type instantiation sequence.
handle::clone()
returnsresult<handle>
, and using C++20result
requires a complete type due to theis_destructible
check intype_can_be_used_in_basic_result
. But at this point thehandle
class is still incomplete.The text was updated successfully, but these errors were encountered: