Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially outdated documentation #280

Closed
jeromehue opened this issue Jul 12, 2023 · 2 comments
Closed

Potentially outdated documentation #280

jeromehue opened this issue Jul 12, 2023 · 2 comments

Comments

@jeromehue
Copy link

Being new to error handling in C++, I tried to follow the example for the standalone single-header experimental library available at https://ned14.github.io/outcome/experimental/worked-example/.

However, the code snippet from this page :
https://ned14.github.io/outcome/experimental/worked-example/implicit_conversion/ :

inline outcome_e::system_code make_status_code(file_io_error v)
{
  return make_status_code_ptr(std::move(v));
}

is not compiling, since make_status_code_ptr() has been removed from the library.
From what I understand, it has been replaced by some make_nested_status_code() function in the status_code repo, but that is not included in the single-header version.

So what will be an equivalent of this example that works with the current version of the library ?

@ned14 ned14 added the bug label Jul 13, 2023
@ned14
Copy link
Owner

ned14 commented Jul 13, 2023

Indeed you're right. Sorry about that.

ned14 added a commit that referenced this issue Jul 13, 2023
LEWG renaming changes of make_nested_status_code().
@ned14
Copy link
Owner

ned14 commented Jul 13, 2023

Fixed, with correct docs now at https://ned14.github.io/outcome/experimental/worked-example/implicit_conversion/.

Thanks for reporting this issue, I don't know why the CI didn't spot it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants