Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete and some post #4

Closed
wants to merge 17 commits into from

Conversation

ebsaral
Copy link

@ebsaral ebsaral commented Jan 14, 2015

What I did?

  • Created the "delete" delegate for the client after creating Destroyer
  • Enhanced Poster to return an object instead of a simple response. I am not sure if it should be backward compatible but I implemented in this way.
  • Added a new data model in poster for event creation.
  • Added spec (more tests needed to validate event creation and deleting feature even though I tested it many times on local). I can add them later.
  • Updated ReadMe.
  • Drank lots of coffee (irrelevant data) lol.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) when pulling 3bd0975 on eminbugrasaral:feature/delete-post into 07b0309 on neektza:master.

@ebsaral ebsaral changed the title Feature/delete post Feature/delete and post Jan 14, 2015
@ebsaral ebsaral changed the title Feature/delete and post Feature/delete and some post Jan 14, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.96%) when pulling 361b55b on eminbugrasaral:feature/delete-post into 07b0309 on neektza:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.96%) when pulling 4e65b40 on eminbugrasaral:feature/delete-post into 07b0309 on neektza:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.96%) when pulling 361b55b on eminbugrasaral:feature/delete-post into 07b0309 on neektza:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.96%) when pulling 361b55b on eminbugrasaral:feature/delete-post into 07b0309 on neektza:master.

@neektza
Copy link
Owner

neektza commented Jan 21, 2015

One nitpick ...

What is the intention behind client.post(:event, { ... new_event_data ... }) returning an Event object instead of just returning a plain hash?

@neektza
Copy link
Owner

neektza commented Jan 21, 2015

Nevermind, I'll merge this anyway because the library will be going in this way anyway. Every response will be an object because it'll enable us the build more fluent APIs.

@neektza
Copy link
Owner

neektza commented Jan 21, 2015

Merged by 3871205

@neektza neektza closed this Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants