Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 18 - Matching not working for path "/" #19

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Conversation

neetjn
Copy link
Owner

@neetjn neetjn commented Oct 2, 2019

Answer the following depending on the type of change you want to merge

Code

  1. Have you added test(s) for your patch? If not, why not?

Yes.

  1. Can you provide an example of your patch in use?

In test.

  1. Is this a breaking change?

No

Content

Provide a short description about what you have changed:

In this pull request I've provided a fix for issue 18.

@neetjn neetjn added the bug Something isn't working label Oct 2, 2019
@neetjn neetjn added this to the 0.0.2 milestone Oct 2, 2019
@neetjn neetjn self-assigned this Oct 2, 2019
@neetjn
Copy link
Owner Author

neetjn commented Oct 2, 2019

A test should be included to ensure this behavior does not break again.

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #19 into 0.0.2 will increase coverage by 14.63%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##            0.0.2      #19       +/-   ##
===========================================
+ Coverage   56.09%   70.73%   +14.63%     
===========================================
  Files           1        1               
  Lines         205      205               
  Branches       53       53               
===========================================
+ Hits          115      145       +30     
+ Misses         67       45       -22     
+ Partials       23       15        -8
Impacted Files Coverage Δ
dist/router.dev.js 70.73% <50%> (+14.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80439f7...4ed3e34. Read the comment docs.

@neetjn neetjn merged commit 4756f8d into 0.0.2 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants