Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Matching not working for path "/" #18

Closed
neetjn opened this issue Oct 1, 2019 · 2 comments
Closed

Bug: Matching not working for path "/" #18

neetjn opened this issue Oct 1, 2019 · 2 comments
Assignees
Labels
bug Something isn't working discussion Open to discussion
Milestone

Comments

@neetjn
Copy link
Owner

neetjn commented Oct 1, 2019

Describe the bug
The matching logic for the router is not matching the path "/".

Ref: https://github.com/neetjn/core-routing/blob/master/src/router.ts#L62
In example: https://github.com/neetjn/riot-routing-prototype/blob/master/src/components/router.riot#L38

To Reproduce
Steps to reproduce the behavior:

  1. Create a new instance of the router.
  2. In the interface, on either onStart or onNavigate -- try matching the current or incoming route path with "/".
  3. Notice there is no match.

Expected behavior
The path "/" should properly be matched.

@neetjn neetjn added the bug Something isn't working label Oct 1, 2019
@neetjn neetjn added this to the 0.0.2 milestone Oct 1, 2019
@neetjn neetjn self-assigned this Oct 1, 2019
@neetjn
Copy link
Owner Author

neetjn commented Oct 1, 2019

(9/30/19) Note: Include working embedded plnkr example.

@neetjn
Copy link
Owner Author

neetjn commented Oct 2, 2019

#19

@neetjn neetjn closed this as completed Oct 2, 2019
@neetjn neetjn changed the title Bug - Matching not working for path "/" Bug: Matching not working for path "/" Oct 2, 2019
@neetjn neetjn mentioned this issue Oct 2, 2019
@neetjn neetjn mentioned this issue Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion Open to discussion
Projects
None yet
Development

No branches or pull requests

1 participant