Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cleaning up old images doesn't seem to work as expected (if at all) #134

Closed
neffo opened this issue Nov 27, 2021 · 0 comments · Fixed by #133
Closed

[BUG] Cleaning up old images doesn't seem to work as expected (if at all) #134

neffo opened this issue Nov 27, 2021 · 0 comments · Fixed by #133
Labels
bug

Comments

@neffo
Copy link
Owner

neffo commented Nov 27, 2021

NOTE:
GNOME will sometimes report errors associated extensions if you manually update them via the extensions website. These errors can be resolved by restarting GNOME shell (logging out and then back in again). If it's still creating errors, then please go ahead create an issue.

Describe the bug
A clear and concise description of what the bug is.

Screenshots
Clicking toggle in doesn't clean up old images in order of age, rather it only deletes last selected images if at all

Desktop (please complete the following information):

  • OS: various
  • Extension Version: 36, probably earlier
  • GNOME Version: 40.x

Additional context
Relates to migration to change to image history. Full Bing JSON data history is stored locally, but this isn't being used to identify the oldest images. As we only store the default history (typically 7 days), images older than that won't be deleted if the switch is toggled, and images will be deleted in a strange order if the user select images through the menu or carousel.
@neffo neffo added the bug label Nov 27, 2021
@neffo neffo mentioned this issue Nov 27, 2021
Merged
20 tasks
@neffo neffo linked a pull request Nov 27, 2021 that will close this issue
Version 37 #133
Merged
20 tasks
neffo added a commit that referenced this issue Nov 27, 2021
@neffo
fix image cleanup #134
706c87e
neffo added a commit that referenced this issue Dec 14, 2021
@neffo @krevad @JAKuhr
Version 37 (#133)
81a2f5c 
* Updated Swedish translation (#129) #14
* fix build instructions
* remove lockscreen switch
* use arrow functions
* fix carousel, add view image button to gallery
* fix purging of old images
* fix missing declaration, carousel image sort
* fix image cleanup #134
* fix deleteImage call
* fix gtk3 gui issues
* fix hidden elements in gtk4 settings
* add info button to gallery
* improved debug logging
* dont save thumbs if delete-previous enabled
* fix notify, opening images, & broken about logo
* remove action from notification
* update german translation (#137)
* initial test import and export of JSON data #136
* fix bytearray toString() warnings
* try fix ellipsized image labels #138
* purge missing files from imported image list
* export bing.json by default
* togglable auto export of JSON data and thumbnails
* set background option in prefs fixes and don't force background zoom #38
* fix missing declaration
* clean up gtk3 settings
* unneeded method, fix icon switching and gtk4 prefs
* code clean up remove unneeded code
* switch to current image if invalid
* remove functions implemented in extensionUtils.js
* fix build script
* code clean up
* fix timeout reversions
* fix carousel thumbnail logic
* small tweaks to gallery ui

Co-authored-by: krevad <krevad@users.noreply.github.com>
Co-authored-by: JAKuhr <9527705+JAKuhr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 37 neffo/bing-wallpaper-gnome-extension
1 participant
@neffo