Version 41 #170
Merged
Version 41 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 4, 2022
siddhpant
reviewed
Sep 15, 2022
| this.logger.attach(this.httpSession); | ||
| this.logger.set_printer(soupPrinter); | ||
| } | ||
| Soup.Session.prototype.add_feature.call(this.httpSession, new Soup.ProxyResolverDefault()); // unclear if this is necessary |
There was a problem hiding this comment.
This causes a crash:
Soup.ProxyResolverDefault is not a constructor
GNOME Shell 42.4 on Debian testing.
There was a problem hiding this comment.
Definitely GNOME 42? Not a beta version of GNOME 43?
I ask because GNOME 43 imports Soup3 by default which is causing some issues (including the above error).
I'm comfortable with removing this line though.
There was a problem hiding this comment.
Yes, it's 42.4. See https://tracker.debian.org/pkg/gnome-shell.
Maybe the change was introduced in or before 42.4 instead of 43.
There was a problem hiding this comment.
Yeah possible they've moved to Soup 3, so probably related to #181
There was a problem hiding this comment.
This should be working in PR #177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this release: