Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pkg for standalone binary bundling #511

Merged
merged 7 commits into from
Oct 2, 2022
Merged

Use pkg for standalone binary bundling #511

merged 7 commits into from
Oct 2, 2022

Conversation

dnaka91
Copy link
Contributor

@dnaka91 dnaka91 commented Oct 2, 2022

My attempt to get pkg working as an alternative to nexe, so we're not bound to Node 12.16.2 anymore. So far seems to work, as far as I could tell, but I didn't test much of any specific features.

Probably there is some duplicate in the package.json by double-bundling release/*.js as scripts AND assets. Thought to look into that a bit further, but maybe best to verify that everything works and then we can tweak the settings.

You mentioned some special behavior with nexe and vm2 for the scripting feature. Maybe you can give that a quick try with this PR or tell me how to test that myself?

@vercel
Copy link

vercel bot commented Oct 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
meme-box ✅ Ready (Inspect) Visit Preview Oct 2, 2022 at 3:17PM (UTC)

@negue
Copy link
Owner

negue commented Oct 2, 2022

Oh this is awesome!!! I don't know exactly what it was that I couldn't use pkg back then but hopefully it works now :)

During each build_executables it triggers

  • run: release/out/memebox --cli-test-mode=true --config=./release/config

Which internally starts memebox itself
a) can it startup without any issues and
b) starts a script to test the vm2 package

soo once the CI goes past the nexe (now pkg) command we'll know if all works out

@negue
Copy link
Owner

negue commented Oct 2, 2022

Tested it locally awesome!! - it works

Thank you for that - that was a long time issue with all the node12 build issues because of nexe - merging that in

Would you like to be added to the contributors list?

@negue negue merged commit 31d841f into negue:develop Oct 2, 2022
@negue negue mentioned this pull request Oct 2, 2022
@dnaka91 dnaka91 deleted the pkg branch October 3, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants