fix(acm): crossplane-contrib#735 fixed synced false for private ca

Signed-off-by: Christopher Haar <chhaar30@googlemail.com>
negz · Nov 11, 2021 · 104254c · 104254c
1 parent 0a6a35d
commit 104254c
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/pkg/controller/acm/controller.go b/pkg/controller/acm/controller.go
@@ -208,21 +208,23 @@ func (e *external) Update(ctx context.Context, mgd resource.Managed) (managed.Ex
 		}
 	}
 
-	// Update the Certificate Option
-	if cr.Spec.ForProvider.CertificateTransparencyLoggingPreference != nil {
-		_, err := e.client.UpdateCertificateOptionsRequest(&awsacm.UpdateCertificateOptionsInput{
-			CertificateArn: aws.String(meta.GetExternalName(cr)),
-			Options:        &awsacm.CertificateOptions{CertificateTransparencyLoggingPreference: *cr.Spec.ForProvider.CertificateTransparencyLoggingPreference},
-		}).Send(ctx)
+	// the UpdateCertificateOptions command is not permitted for private certificates.
+	if cr.Status.AtProvider.Type != awsacm.CertificateTypePrivate {
+		// Update the Certificate Option
+		if cr.Spec.ForProvider.CertificateTransparencyLoggingPreference != nil {
+			_, err := e.client.UpdateCertificateOptionsRequest(&awsacm.UpdateCertificateOptionsInput{
+				CertificateArn: aws.String(meta.GetExternalName(cr)),
+				Options:        &awsacm.CertificateOptions{CertificateTransparencyLoggingPreference: *cr.Spec.ForProvider.CertificateTransparencyLoggingPreference},
+			}).Send(ctx)
 
-		if err != nil {
-			return managed.ExternalUpdate{}, awsclient.Wrap(err, errUpdate)
+			if err != nil {
+				return managed.ExternalUpdate{}, awsclient.Wrap(err, errUpdate)
+			}
 		}
 	}
 
 	// Renew the certificate if request for RenewCertificate and Certificate is eligible
 	if aws.BoolValue(cr.Spec.ForProvider.RenewCertificate) {
-
 		if cr.Status.AtProvider.RenewalEligibility == awsacm.RenewalEligibilityEligible {
 			_, err := e.client.RenewCertificateRequest(&awsacm.RenewCertificateInput{
 				CertificateArn: aws.String(meta.GetExternalName(cr)),