Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: state revamp #722

Merged
merged 107 commits into from
Jun 9, 2020
Merged

Refactor: state revamp #722

merged 107 commits into from
Jun 9, 2020

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Jun 2, 2020

Related issues and PRs

Description

This PR:

  • moves all shared state into Redux store, connects components
  • removes props drilling
  • avoids unnecessary renders caused by inconsistent state and props changes
  • moves side-effects to sagas
  • only dbounces what's necessary
  • makes interface less laggy
  • brings back translations
  • moves data loaders to io/ directory (to share with cli and npm package)
  • automatically persists settings state in local storage
  • moves plot data generation from component into the worker (computes once)
  • implements small cosmetic fixes and improvements

Impacted Areas in the application

React components and pages

Testing

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6529 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6673 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6531 lines exceeds the maximum allowed for the inline comments feature.

@vercel vercel bot temporarily deployed to Preview June 9, 2020 00:16 Inactive
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6563 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6571 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6571 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Jun 9, 2020

Code Climate has analyzed commit e0ad60f and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants