Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find instead of mv * to avoid "argument list too long" error. #9

Closed
wants to merge 1 commit into from

Conversation

gaberoo
Copy link

@gaberoo gaberoo commented Nov 28, 2018

On macOS:

For a large number of genes, mv returns a 'argument list too long' error. Using find instead of wildcard expansion fixes this.

@rneher
Copy link
Member

rneher commented Dec 2, 2018

Thanks, Gabriel. I'll test this on linux (and maybe change to using shutil instead of os.system).

@gaberoo
Copy link
Author

gaberoo commented Dec 2, 2018

Ah yes, good idea. shutil.move is probably the best solution for cross-platform consistency. That probably applies to the other copy/move operations in this step as well.

@rneher
Copy link
Member

rneher commented Dec 2, 2018

Could you test whether the branch shutil_to_move_files works for you? Works on the Testset.

@rneher
Copy link
Member

rneher commented Dec 2, 2018

hold on, I screwed up...

@rneher
Copy link
Member

rneher commented Dec 2, 2018

now it should work

@rneher rneher mentioned this pull request Dec 30, 2018
@rneher
Copy link
Member

rneher commented Dec 30, 2018

I merged the branch shutil_to_move which should address this problem. Thanks again for pointing it out.

@rneher rneher closed this Dec 30, 2018
@gaberoo
Copy link
Author

gaberoo commented Dec 31, 2018

Great! Sorry I didn't get around to test this... I don't expect to need to, but in case something doesn't pan out I will reopen an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants