Add ignore_missing_alns option to TreeAnc to extend use cases #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #177
Context
When doing ancestral state reconstruction with a tree that has many tips without alignment (>1/3), treetime throws an error.
This PR introduces a new constructor parameter
ignore_missing_alns=False
that defaults toFalse
in a backward compatible manner. Setting it to true means that no error is raised even when more than 1/3 of tips don't have alignments attached.This extends use cases.
Testing
Tested with my script that needs this feature and both
True
andFalse
do exactly what they're supposed to do. No error vs error.Usage
Other commits
I noticed that defaults weren't documented in numpy style in the docs, so I fixed it where I saw it. Also fixed a typo and indentation.