Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUPH-75 | Support fully qualified traits #65

Merged
merged 2 commits into from
Nov 19, 2021
Merged

BUPH-75 | Support fully qualified traits #65

merged 2 commits into from
Nov 19, 2021

Conversation

jpmarcotte
Copy link
Contributor

@jpmarcotte jpmarcotte commented May 19, 2021 •
edited
Loading

Only applies to V1.

@jpmarcotte jpmarcotte self-assigned this May 19, 2021
@jpmarcotte jpmarcotte changed the title BUPH-75 | add broken tests for fully qualified traits BUPH-75 | Support fully qualified traits May 25, 2021
arielallon
arielallon approved these changes Nov 18, 2021
View reviewed changes
Copy link

@arielallon arielallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me but i'm also not certain what to be looking for.

@jpmarcotte
Copy link
Contributor Author

jpmarcotte commented Nov 18, 2021 •
edited
Loading

i'm also not certain what to be looking for.

I just added autolinks, but it doesn't seem to have taken effect for this already existing PR. This should sum it up: https://55places.atlassian.net/browse/BUPH-75

mucha55
mucha55 approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@mucha55 mucha55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting test setup 😅

@jpmarcotte
Copy link
Contributor Author

That's an interesting test setup 😅

Yeah, it felt like full integration tests were more appropriate than trying to just test specifics of the internals with something like PHPUnit, especially because we were planning on reworking a bunch of the internals.

@jpmarcotte jpmarcotte merged commit e2a966e into master Nov 19, 2021
@jpmarcotte jpmarcotte deleted the BUPH-75-fully-qualified-traits branch November 19, 2021 17:00
@jpmarcotte jpmarcotte mentioned this pull request Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielallon arielallon arielallon approved these changes

@mucha55 mucha55 mucha55 approved these changes

Assignees

@jpmarcotte jpmarcotte

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpmarcotte @arielallon @mucha55