Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX | Upgrade Symfony & Maps to work on PHP 8.1 #70

Merged
merged 6 commits into from
Oct 11, 2021
Merged

HOTFIX | Upgrade Symfony & Maps to work on PHP 8.1 #70

merged 6 commits into from
Oct 11, 2021

Conversation

jpmarcotte
Copy link
Contributor

No description provided.

@jpmarcotte jpmarcotte self-assigned this Oct 4, 2021
@jpmarcotte jpmarcotte changed the base branch from master to HOTFIX-error-handlers-for-php81 October 4, 2021 18:25
arielallon
arielallon approved these changes Oct 4, 2021
View reviewed changes
Copy link

@arielallon arielallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be released as a minor version bump of buphalo

@jpmarcotte jpmarcotte changed the title HOTFIX | upgrade to a symfony finder version that works on PHP 8.1 HOTFIX | Upgrade Symfony & Maps to work on PHP 8.1 Oct 6, 2021
@jpmarcotte
Copy link
Contributor Author

should probably be released as a minor version bump of buphalo

Good idea. Once this gets fully approved, I'll open a new PR with stuff that only affects the 1.x branch.

mucha55
mucha55 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@mucha55 mucha55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've expected these to all be fabbed, but I guess we don't want prefab to be a dependency of buphalo :)

Base automatically changed from HOTFIX-error-handlers-for-php81 to master October 11, 2021 15:10
@jpmarcotte
Copy link
Contributor Author

I would've expected these to all be fabbed, but I guess we don't want prefab to be a dependency of buphalo :)

Yeah, the eventual goal is to have Buphalo buphalo Buphalo, but that hasn't happened yet.

@jpmarcotte jpmarcotte merged commit 9e8d9af into master Oct 11, 2021
@jpmarcotte jpmarcotte deleted the HOTFIX-symfony-finder-for-php81 branch October 11, 2021 15:13
@jpmarcotte jpmarcotte mentioned this pull request Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielallon arielallon arielallon approved these changes

@mucha55 mucha55 mucha55 approved these changes

Assignees

@jpmarcotte jpmarcotte

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpmarcotte @arielallon @mucha55