New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid splitting base64-encoded single fields (RT 123211) #5

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@openstrike

openstrike commented May 11, 2018

As suggested in RT 123211 this PR uses the empty-string separator for those calls to encode_base64 where a single field is being supplied (typically username or password). We don't have a test for this but the logic seems sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment