Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a templating system to handle more complex set ups #98

Merged
merged 13 commits into from
Jun 30, 2019
Merged

Conversation

neild3r
Copy link
Owner

@neild3r neild3r commented Dec 27, 2018

This is the start of a change to add a templating system in to the package to allow for uses to do a more advanced configuration of how they want their docblocks to be displayed and would allow people to move things around or remove params by creating their own templates.

The key difficulty I have at the moment is with the old configs for adding in gaps which could now be made redundant but also for what happens to gaps when certain parameters aren't defined such as a gap between params and return when there is no return or no params or neither. Perhaps this change can make things a bit too messy

@neild3r
Copy link
Owner Author

neild3r commented Jan 11, 2019

I've now amended this to work as a config object instead of a template in the strictest form there are some more additions to be made but this feels like it is on the right track for managing gaps etc in a properly controlled way

@jens1o
Copy link
Contributor

jens1o commented Jan 11, 2019

LGTM.

@neild3r
Copy link
Owner Author

neild3r commented Jan 12, 2019

See https://github.com/neild3r/vscode-php-docblocker/blob/templates/README.md#templating for examples on how to use the new templating system

@AeonFr
Copy link

AeonFr commented Apr 12, 2019

Can this feature be used today? This sounds like a nice thing to have.

@neild3r neild3r merged commit a45199b into master Jun 30, 2019
@neild3r neild3r deleted the templates branch June 30, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants