Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it be lmd * np.linalg.inv(gmat) as in the paper? #49

Closed
Sunzhiliang opened this issue Oct 6, 2020 · 1 comment
Closed

Should it be lmd * np.linalg.inv(gmat) as in the paper? #49

Sunzhiliang opened this issue Oct 6, 2020 · 1 comment

Comments

@Sunzhiliang
Copy link

sigma_mat_inv = lmd * gmat + s2s2 * np.diag(nu)

If we follow the paper,it shoud be
sigma_mat_inv = lmd * gmat + s2s2 * np.diag(nu).
However, if it is changed,the result is wrong.
Is it wrong to use "np.linalg.inv(gmat)" in the paper?

neka-nat added a commit that referenced this issue Oct 6, 2020
@neka-nat
Copy link
Owner

neka-nat commented Oct 6, 2020

Thank you!
I've pushed fixes #48 and this issue to master.
Fixing both is working fine for the bunny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants