Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chatのURLを変更する #38

Closed
1 task done
keitakn opened this issue Jun 29, 2023 · 1 comment
Closed
1 task done

chatのURLを変更する #38

keitakn opened this issue Jun 29, 2023 · 1 comment
Assignees
@keitakn

Comments

@keitakn
Copy link
Member

keitakn commented Jun 29, 2023 •
edited

完了の定義

  • /chat のURLにねこの名前が入るように変更されている事

補足情報

今はこのURLで良いが後の為に対応しておく。
@keitakn keitakn self-assigned this Jun 29, 2023
keitakn added a commit that referenced this issue Jul 1, 2023
@keitakn
🚧 #38
4ea65e1
@keitakn keitakn mentioned this issue Jul 1, 2023
Merged
keitakn added a commit that referenced this issue Jul 1, 2023
@keitakn
🎨 #38 /chat のURLは catId を必須に変更
d87b2c5
keitakn added a commit that referenced this issue Jul 1, 2023
@keitakn
🎨 #38 バックエンド側では cat_id として扱っているので catId に変更
f069b20
@keitakn
Copy link
Member Author

keitakn commented Jul 1, 2023 •
edited

次にやる事

  • catId から日本語のねこの名前を取得する処理を実装
  • 存在しない catId が指定されたら404ページを表示するように変更

keitakn added a commit that referenced this issue Jul 2, 2023
@keitakn
✨ #38 リテラル型の網羅性チェック用に ExhaustiveError を実装
24fc534
keitakn added a commit that referenced this issue Jul 2, 2023
@keitakn
✨ #38 ねこのIDからねこの名前を取り出す関数を実装
8b835f8
keitakn added a commit that referenced this issue Jul 4, 2023
@keitakn
🎨 #38 存在しないcatIdが指定された場合は404を返すように変更
2a1cee2
keitakn added a commit that referenced this issue Jul 4, 2023
@keitakn
✅ #38 isCatId のテストコードを実装
1320590
keitakn added a commit that referenced this issue Jul 4, 2023
@keitakn
✅ #38 extractCatNameById のテスト追加とディレクトリの整理
3fd80aa
keitakn added a commit that referenced this issue Jul 4, 2023
@keitakn
💚 #38 TestTable の型定義に余計な物が入っていたので削除
a27f596
keitakn added a commit that referenced this issue Jul 4, 2023
@keitakn
♻️ #38 エラークラスなので errors に格納するように変更
a611cb0
@keitakn keitakn closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keitakn keitakn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keitakn