/chat のURLを変更 #40
Merged
/chat のURLを変更 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 16 +4
Lines 39 56 +17
Branches 2 5 +3
=========================================
+ Hits 39 56 +17
☔ View full report in Codecov by Sentry. |
keitakn
commented
Jul 4, 2023
| @@ -26,7 +26,7 @@ describe('src/api/client/fetchCatMessage.ts fetchCatMessage TestCases', () => { | |||
|
|
|||
| it('should be able to fetch a CatMessage', async () => { | |||
| const fetchedResponse = await fetchCatMessage({ | |||
| catName: 'moko', | |||
There was a problem hiding this comment.
バックエンド側では cat_id なので合わせて変更した。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#38
この PR で対応する範囲 / この PR で対応しない範囲
#38 のDoneの定義を満たす実装はこのPRで全て完了させる。
Storybook の URL、 スクリーンショット
UI変更は行っていないのでなし。
変更点概要
/chatのURLを/chat/mokoのようにねこのIDを入れる形に変更。これは今後、ねこのIDが増えた際にURLを変えたくないので、今のうちに対応したかったので対応した。
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
インラインコメントに記載。