Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expression evaluator do not error that much #1137

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

ChristopherHX
Copy link
Contributor

Why does the new expression evaluator returns far more errors than the original?
I can't get fromJSON('[0,1]')['1.1'] to work, it doesn't return null.

Closes #1071
Closes #1115

@ChristopherHX ChristopherHX requested a review from a team as a code owner April 20, 2022 21:14
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 0.86s
✅ EDITORCONFIG editorconfig-checker 2 0 0.52s
✅ GIT git_diff yes no 0.01s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1137 (17b16dc) into master (4f8da0a) will increase coverage by 2.55%.
The diff coverage is 79.21%.

@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
+ Coverage   57.50%   60.06%   +2.55%     
==========================================
  Files          32       39       +7     
  Lines        4594     4938     +344     
==========================================
+ Hits         2642     2966     +324     
  Misses       1729     1729              
- Partials      223      243      +20     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/model/workflow.go 50.91% <ø> (ø)
pkg/container/docker_run.go 5.11% <2.50%> (-0.43%) ⬇️
pkg/common/git.go 49.31% <28.57%> (-0.52%) ⬇️
pkg/container/file_collector.go 44.85% <44.85%> (ø)
pkg/runner/logger.go 66.00% <67.56%> (+0.56%) ⬆️
pkg/runner/runner.go 73.72% <73.68%> (-2.75%) ⬇️
pkg/runner/expression.go 89.31% <78.26%> (-1.51%) ⬇️
pkg/exprparser/interpreter.go 75.54% <78.94%> (+2.14%) ⬆️
... and 19 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 9357512 into master Apr 26, 2022
@mergify mergify bot deleted the exprevalfixes2 branch April 26, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: act cannot evaluate if-condition (Unable to index on non-slice value: invalid) Error in if-expression
2 participants