Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic while running DRYRUN with local actions #1141

Merged
merged 2 commits into from
May 11, 2022

Conversation

ChristopherHX
Copy link
Contributor

With this change act's dryrun no longer panics after my previous change #719. An error is better than a panic.

We need to consider how act can support dryrun for localactions.

Closes #1140

@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 0.9s
✅ EDITORCONFIG editorconfig-checker 1 0 0.58s
✅ GIT git_diff yes no 0.0s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1141 (d3b83e1) into master (4f8da0a) will increase coverage by 2.49%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
+ Coverage   57.50%   60.00%   +2.49%     
==========================================
  Files          32       39       +7     
  Lines        4594     4993     +399     
==========================================
+ Hits         2642     2996     +354     
- Misses       1729     1749      +20     
- Partials      223      248      +25     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <ø> (ø)
pkg/model/github_context.go 79.51% <ø> (ø)
pkg/model/planner.go 50.73% <ø> (+0.32%) ⬆️
pkg/model/workflow.go 50.91% <ø> (ø)
pkg/container/docker_run.go 5.01% <1.96%> (-0.53%) ⬇️
pkg/common/git.go 49.31% <28.57%> (-0.52%) ⬇️
pkg/container/file_collector.go 44.85% <44.85%> (ø)
pkg/runner/runner.go 73.72% <73.68%> (-2.75%) ⬇️
pkg/exprparser/interpreter.go 75.29% <75.00%> (+1.89%) ⬆️
pkg/runner/logger.go 69.56% <75.47%> (+4.13%) ⬆️
... and 20 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ChristopherHX ChristopherHX marked this pull request as ready for review May 4, 2022 20:01
@ChristopherHX ChristopherHX requested a review from a team as a code owner May 4, 2022 20:01
@mergify mergify bot merged commit 562265b into master May 11, 2022
@mergify mergify bot deleted the fix-panic-localaction-dryrun branch May 11, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: signal SIGSEGV: segmentation violation
4 participants