fix: processing of strategy.matrix.include #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
==========================================
+ Coverage 57.50% 61.98% +4.47%
==========================================
Files 32 40 +8
Lines 4594 5437 +843
==========================================
+ Hits 2642 3370 +728
- Misses 1729 1797 +68
- Partials 223 270 +47
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ChristopherHX
commented
Jun 17, 2022
Comment on lines
230
to
244
| case []interface{}: | ||
| for _, i := range t { | ||
| i := i.(map[string]interface{}) | ||
| extraInclude := true | ||
| for k := range i { | ||
| if _, ok := m[k]; ok { | ||
| includes = append(includes, i) | ||
| extraInclude = false | ||
| break | ||
| } | ||
| } | ||
| if extraInclude { | ||
| extraIncludes = append(extraIncludes, i) | ||
| } | ||
| } |
There was a problem hiding this comment.
Why do we have this case? Doesn't this allow invalid syntax.
ChristopherHX
commented
Jun 17, 2022
pkg/model/workflow_test.go
Outdated
| @@ -247,6 +247,7 @@ func TestReadWorkflow_Strategy(t *testing.T) { | |||
| {"datacenter": "site-c", "node-version": "14.x", "site": "staging"}, | |||
| {"datacenter": "site-c", "node-version": "16.x", "site": "staging"}, | |||
| {"datacenter": "site-d", "node-version": "16.x", "site": "staging"}, | |||
| {"php-version": 5.4}, | |||
There was a problem hiding this comment.
I modified this Test, correct me if my expectation is wrong.
KnisterPeter
approved these changes
Jun 20, 2022
cplee
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored GetMatrices to more closely match my runner.server project and github actions.
Partially fixes #769
fixes #1182
resolves #1223
Known Issues, based on recent research in my related project
null == '' == 0