Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow TimeoutMinutes to be expression #1217

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

catthehacker
Copy link
Member

fixes #1216

@github-actions
Copy link
Contributor

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 0.93s
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ GIT git_diff yes no 0.0s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1217 (127a47c) into master (4f8da0a) will increase coverage by 4.67%.
The diff coverage is 76.73%.

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
+ Coverage   57.50%   62.18%   +4.67%     
==========================================
  Files          32       40       +8     
  Lines        4594     5345     +751     
==========================================
+ Hits         2642     3324     +682     
- Misses       1729     1760      +31     
- Partials      223      261      +38     
Impacted Files Coverage Δ
pkg/container/docker_pull.go 33.33% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/github_context.go 79.51% <ø> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/model/workflow.go 54.29% <0.00%> (+3.38%) ⬆️
pkg/container/docker_run.go 15.18% <22.52%> (+9.64%) ⬆️
pkg/common/git/git.go 49.66% <40.00%> (ø)
pkg/container/file_collector.go 44.85% <44.85%> (ø)
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
pkg/model/planner.go 50.73% <60.00%> (+0.32%) ⬆️
... and 27 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@catthehacker catthehacker marked this pull request as ready for review June 14, 2022 22:12
@catthehacker catthehacker requested a review from a team as a code owner June 14, 2022 22:12
@mergify mergify bot merged commit 52f5c45 into master Jun 16, 2022
@mergify mergify bot deleted the fix/timeout-minutes branch June 16, 2022 20:57
mergify bot added a commit that referenced this pull request Jul 8, 2022
This change stops act from rejecting valid entries such as

```
    timeout-minutes: ${{ matrix.runtime == 'v8' && 30 || 15 }}
```

at the job level.

This change complements the fix that was already in place
for the Step struct, done in #1217. See:

52f5c45

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing of Yaml workflow file fails with valid github action syntax
3 participants