Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: share UpdateFromEnv logic #1457

Merged
merged 5 commits into from
Dec 6, 2022

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Nov 23, 2022

No public interface has been changed.

TODO

  • Add tests for bugs of the old docker_run impl.
  • Add tests for GITHUB_OUTPUT / GITHUB_STATE

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.03s
✅ REPOSITORY gitleaks yes no 2.91s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 1.22s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1457 (fa8753e) into master (4f8da0a) will increase coverage by 3.53%.
The diff coverage is 67.15%.

@@            Coverage Diff             @@
##           master    #1457      +/-   ##
==========================================
+ Coverage   57.50%   61.04%   +3.53%     
==========================================
  Files          32       45      +13     
  Lines        4594     6955    +2361     
==========================================
+ Hits         2642     4246    +1604     
- Misses       1729     2408     +679     
- Partials      223      301      +78     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/parse_env_file.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 13.58% <11.48%> (+8.04%) ⬆️
pkg/model/workflow.go 45.65% <23.58%> (-5.26%) ⬇️
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChristopherHX ChristopherHX marked this pull request as ready for review November 23, 2022 22:30
@ChristopherHX ChristopherHX requested a review from a team as a code owner November 23, 2022 22:30
@mergify mergify bot merged commit 57bf4d2 into master Dec 6, 2022
@mergify mergify bot deleted the share-env-file-parser-container-host branch December 6, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants