refactor: move autoremove into the jobexecutor #1463
Conversation
breaking: docker container are removed after job exit
|
@ChristopherHX this pull request has failed checks 🛠 |
|
@ChristopherHX this pull request has failed checks 🛠 |
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
+ Coverage 57.50% 60.59% +3.08%
==========================================
Files 32 44 +12
Lines 4594 6991 +2397
==========================================
+ Hits 2642 4236 +1594
- Misses 1729 2451 +722
- Partials 223 304 +81
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page MegaLinter is graciously provided by |
| logger.WithField("jobResult", "success").Infof("\U0001F3C1 Job succeeded") | ||
| var err error | ||
| if rc.Config.AutoRemove || jobError == nil { | ||
| err = info.stopContainer()(ctx) |
There was a problem hiding this comment.
This will fail if the job was canceled before (e.g. by os signal).
Please make sure that a fallback context is used in that case.
There was a problem hiding this comment.
I changed the code to allow docker 1min for closing / removing the runner. Should be safe now.
Additionally I now reuse the existing joblogger instead of creating one. I always want to use my own logger provided to the RunContext executor.
Do we want to add a forceCancel context as field to the context, so we can force quit act by pressing ctrl+c twice? This could be the parent context of the context with a timeout.
Needs to be tested manually, I don't think we have tests for cancelling act.
There was a problem hiding this comment.
Do we want to add a forceCancel context as field to the context, so we can force quit act by pressing ctrl+c twice? This could be the parent context of the context with a timeout.
That was the case before. The BackgroundContext used as a fallback was cancelable as well. That would then cancel/stop the cleanup.
There was a problem hiding this comment.
That was the case before. The BackgroundContext used as a fallback was cancelable as well. That would then cancel/stop the cleanup.
I want both a normal cancel with cleanup and additionally the opportunity to send another cancellation signal to abort cleanup and quit as soon as possible.
Previously we had one of them, but never both at the same time.
For Example this scenario
- Start a long running job
- cancel the normal context it while it executes the main stage
- A new context for the post executors is created
- This job has a long runnng post step
- cancel again this time force cancel context, because I don't want to wait otherwise I have to open the task manager and kill act.
- act stopped before hit 5min
Your CI system could just never fire the forcecancel context and you have an opt out.
There was a problem hiding this comment.
I understood and I'm fine with that.
I just thought that it did work before, as a second cancelation was respected by act (if I remember correctly).
… we were cancelled
breaking: docker container are removed after job exit
In github-act-runner I directly instantiate the RunContext, but I also want to make use of autoremove due to randomized job container name.