Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarifying skipping steps / jobs #1480

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

ChristopherHX
Copy link
Contributor

Some people try to use something for step level if on job level. Make it clear that this is not supposed to work.

Fixes #1474

@ChristopherHX ChristopherHX requested a review from a team as a code owner November 28, 2022 17:00
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ MARKDOWN markdownlint 1 0 0.28s
✅ REPOSITORY gitleaks yes no 2.7s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.89s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1480 (9e1ea46) into master (4f8da0a) will increase coverage by 2.89%.
The diff coverage is 66.59%.

@@            Coverage Diff             @@
##           master    #1480      +/-   ##
==========================================
+ Coverage   57.50%   60.40%   +2.89%     
==========================================
  Files          32       44      +12     
  Lines        4594     7000    +2406     
==========================================
+ Hits         2642     4228    +1586     
- Misses       1729     2465     +736     
- Partials      223      307      +84     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 12.82% <11.53%> (+7.27%) ⬆️
pkg/model/workflow.go 45.65% <23.58%> (-5.26%) ⬇️
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 28, 2022
@20k-ultra
Copy link

is mergify suppose to kick in here and merge .. ?

@KnisterPeter
Copy link
Member

Multiple approvals are required

@mergify mergify bot merged commit 7073eac into master Dec 6, 2022
@mergify mergify bot deleted the clarifying-skipping-jobs-steps branch December 6, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env.act not working with github actions
4 participants