fix: preserve job result state in case of failure #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is just one job field for the job result. This is also true for matrix jobs. We need to preserve the failure state of a job to have the whole job failing in case of one permuation of the matrix failed. Closes #1518
KnisterPeter
commented
Dec 19, 2022
Comment on lines
134
to
+139
| jobResult := "success" | ||
| jobResultMessage := "succeeded" | ||
| // we have only one result for a whole matrix build, so we need | ||
| // to keep an existing result state if we run a matrix | ||
| if len(info.matrix()) > 0 && rc.Run.Job().Result != "" { | ||
| jobResult = rc.Run.Job().Result | ||
| } |
There was a problem hiding this comment.
I'm not too happy with this approach, but it is currently the right fix.
We should make this a bigger refactoring to integrate the continue-on-error for jobs and maybe rethink matrix handling.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
==========================================
+ Coverage 61.22% 61.26% +0.04%
==========================================
Files 46 46
Lines 7141 7149 +8
==========================================
+ Hits 4372 4380 +8
Misses 2462 2462
Partials 307 307
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This feature is not yet supported by act and if implemented would make this test invalid
ChristopherHX
approved these changes
Dec 19, 2022
cplee
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is just one job field for the job result. This is also true for
matrix jobs. We need to preserve the failure state of a job to
have the whole job failing in case of one permuation of the matrix failed.
Closes #1518