Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed auto-generated platform configuration with Micro size image #1566

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

kakakakakku
Copy link
Contributor

Hi, thank you for such an awesome tool 👍

When I first execute act command with Micro size image, ~/.actrc was generated as below. Because -P -P is the wrong configuration, so I fixed it.

-P ubuntu-latest=node:16-buster-slim
-P -P ubuntu-22.04=node:16-bullseye-slim
 ubuntu-20.04=node:16-buster-slim
-P ubuntu-18.04=node:16-buster-slim

I use the latest version of act.

$ act --version
act version 0.2.40

Could you review please? Thanks!

@kakakakakku kakakakakku requested a review from a team as a code owner January 18, 2023 06:26
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@mergify mergify bot added the needs-work Extra attention is needed label Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1566 (60ec175) into master (4989f44) will increase coverage by 0.55%.
The diff coverage is 76.63%.

@@            Coverage Diff             @@
##           master    #1566      +/-   ##
==========================================
+ Coverage   61.22%   61.77%   +0.55%     
==========================================
  Files          46       46              
  Lines        7141     7140       -1     
==========================================
+ Hits         4372     4411      +39     
+ Misses       2462     2424      -38     
+ Partials      307      305       -2     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.58% <ø> (ø)
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/runner/run_context.go 78.81% <0.00%> (ø)
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/container/docker_auth.go 51.35% <56.25%> (+3.73%) ⬆️
pkg/runner/runner.go 86.45% <66.66%> (-2.05%) ⬇️
pkg/common/git/git.go 57.72% <79.71%> (+7.72%) ⬆️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Jan 18, 2023
@nektos nektos deleted a comment from mergify bot Jan 18, 2023
@mergify mergify bot merged commit 566b9d8 into nektos:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants