Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error instead of panic when walking in a nonexistent dir #1667

Merged
merged 2 commits into from Mar 8, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Mar 7, 2023

fi fs.FileInfo will be nil when err error isn't.

@wolfogre wolfogre requested a review from a team as a code owner March 7, 2023 05:20
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1667 (f8fc7ad) into master (4989f44) will increase coverage by 1.24%.
The diff coverage is 71.05%.

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   61.22%   62.46%   +1.24%     
==========================================
  Files          46       48       +2     
  Lines        7141     7455     +314     
==========================================
+ Hits         4372     4657     +285     
- Misses       2462     2478      +16     
- Partials      307      320      +13     
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 14.08% <0.00%> (+0.49%) ⬆️
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/container/file_collector.go 37.30% <0.00%> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/model/workflow.go 42.11% <ø> (ø)
pkg/model/planner.go 44.71% <21.27%> (-4.12%) ⬇️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit ac5dd8f into nektos:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants