Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: offline mode for new action cache #2173

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

ChristopherHX
Copy link
Contributor

Currently --action-offline-mode is ignored with new-action-cache

  • Try fetch update of the action, otherwise use cached version

* Try fetch update of the action, otherwise use cached version
@ChristopherHX ChristopherHX requested a review from a team as a code owner January 28, 2024 19:32
Copy link
Contributor

github-actions bot commented Jan 28, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.4s
✅ REPOSITORY git_diff yes no 0.16s
✅ REPOSITORY grype yes no 7.29s
✅ REPOSITORY secretlint yes no 1.02s
✅ REPOSITORY trivy-sbom yes no 0.62s
✅ REPOSITORY trufflehog yes no 6.31s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (5a80a04) 61.56% compared to head (018a132) 61.61%.
Report is 13 commits behind head on master.

Files Patch % Lines
pkg/runner/action_cache_offline_mode.go 0.00% 22 Missing ⚠️
pkg/container/docker_socket.go 85.52% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
+ Coverage   61.56%   61.61%   +0.05%     
==========================================
  Files          53       55       +2     
  Lines        9002     9100      +98     
==========================================
+ Hits         5542     5607      +65     
- Misses       3020     3051      +31     
- Partials      440      442       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Jan 30, 2024

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jan 30, 2024
Copy link
Contributor

mergify bot commented Jan 30, 2024

@ChristopherHX this pull request has failed checks 🛠

@ChristopherHX
Copy link
Contributor Author

After fixing codecov yesterday, is the diff coverage 0% and reqires new tests. Put this on my backlog.

@mergify mergify bot removed the needs-work Extra attention is needed label Feb 12, 2024
@mergify mergify bot merged commit 852959e into master Feb 12, 2024
10 checks passed
@mergify mergify bot deleted the feat-offline-mode-new-action-cache branch February 12, 2024 12:51
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
* Try fetch update of the action, otherwise use cached version

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants