Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node16 support #922

Merged
merged 7 commits into from
Dec 22, 2021
Merged

Conversation

catthehacker
Copy link
Member

@catthehacker catthehacker commented Dec 10, 2021

Changes:

  • Bump all images to NodeJS 16.x
  • Add support for node16 in actions

To do:

  • Add support to find the right version of node in the image for each node key
    • node16 finds node in /opt/hostedtoolcache/node/16.*.*/, etc.
      this will be addressed in new PR

Closes #910

@catthehacker catthehacker requested a review from a team as a code owner December 10, 2021 20:39
@mergify

This comment has been minimized.

@mergify mergify bot added the needs-work Extra attention is needed label Dec 10, 2021
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #922 (9428e91) into master (0f04942) will increase coverage by 7.76%.
The diff coverage is 64.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   49.27%   57.03%   +7.76%     
==========================================
  Files          23       28       +5     
  Lines        2401     4224    +1823     
==========================================
+ Hits         1183     2409    +1226     
- Misses       1090     1607     +517     
- Partials      128      208      +80     
Impacted Files Coverage Δ
pkg/common/executor.go 46.90% <0.00%> (+2.03%) ⬆️
pkg/common/job_error.go 0.00% <0.00%> (ø)
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/common/testflag.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 5.54% <14.15%> (+3.61%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/logger.go 65.43% <37.50%> (+1.28%) ⬆️
pkg/container/docker_auth.go 45.00% <45.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9868e13...9428e91. Read the comment docs.

hackercat added 3 commits December 14, 2021 10:15
Signed-off-by: hackercat <me@hackerc.at>
Signed-off-by: hackercat <me@hackerc.at>
Signed-off-by: hackercat <me@hackerc.at>
@mergify mergify bot removed the needs-work Extra attention is needed label Dec 14, 2021
@Poltergeist
Copy link
Contributor

We @ZauberNerd, @KnisterPeter and me looked at this together and we do agree with those changes. And we have no comments for changes.

Poltergeist
Poltergeist previously approved these changes Dec 16, 2021
cplee
cplee previously approved these changes Dec 22, 2021
@mergify

This comment has been minimized.

@mergify mergify bot added the needs-work Extra attention is needed label Dec 22, 2021
@mergify

This comment has been minimized.

@catthehacker catthehacker dismissed stale reviews from cplee and Poltergeist via 0f4d75e December 22, 2021 07:33
@mergify

This comment has been minimized.

@catthehacker
Copy link
Member Author

welp, github linter broke

@mergify

This comment has been minimized.

@mergify mergify bot removed the needs-work Extra attention is needed label Dec 22, 2021
@mergify mergify bot requested a review from a team December 22, 2021 19:27
@catthehacker catthehacker requested a review from a team December 22, 2021 19:28
@mergify mergify bot merged commit 5580812 into nektos:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: node16 runner
3 participants