Allow Symfony 5 #1564
Allow Symfony 5 #1564
Conversation
maxhelias
force-pushed
the
sf5
branch
7 times, most recently
from
cdd159e
to
0565321
Compare
maxhelias
force-pushed
the
sf5
branch
2 times, most recently
from
99b1117
to
169c250
Compare
|
@GuilhemN I think we can merge this PR even if the Sf5 test fails because of FOSRestBundle. It should automatically go green at the next release of FOSRest |
| @@ -37,7 +37,7 @@ public function getExtendedType() | |||
| return self::getExtendedTypes()[0]; | |||
| } | |||
|
|
|||
| public static function getExtendedTypes() | |||
| public static function getExtendedTypes(): iterable | |||
| { | |||
| return [FormType::class]; | |||
There was a problem hiding this comment.
I've not tried this (was just looking at symfony 5 status), but should the return statement not be:
return array(FormType::class);
the addition of array() is in the upgrade doc's example?
There was a problem hiding this comment.
I do not understand what you mean :/
There was a problem hiding this comment.
I happened to read https://github.com/symfony/symfony/blame/master/UPGRADE-5.0.md#L153 about 30 seconds before reading your PR. The symfony guide 'after' example added array()
There was a problem hiding this comment.
@mantis array() and [] are the same thing. It's just two different ways of writing arrays in PHP. [] being more modern.
There was a problem hiding this comment.
argh, sorry - I missed the []
|
Thank you @maxhelias ! :) |
I remove support for PHP 7.1 as she is no longer maintained and she don't support
iterabletype for compatibility with Symfony 5.Add PHP 7.3 and 7.4 tests
Try different versions of Symfony
TODO :