Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes symfony serializer being mandatory #1938

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

magnetik
Copy link
Collaborator

Fixes #1937

I've tested locally but maybe we should have a functional test with symfony serializer not installed?

@GuilhemN GuilhemN merged commit cc6731a into nelmio:master Dec 23, 2021
@GuilhemN
Copy link
Collaborator

Thanks!

I've tested locally but maybe we should have a functional test with symfony serializer not installed?

I guess the only way to test that would be through github actions, by adding more cases to the matrix, this would need some rethinking of our tests though to skip all tests were the Symfony serializer is required...

@magnetik magnetik deleted the 1937 branch December 23, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version crashes if symfony/serializer is not installed
2 participants