update hel to use golang.org/x/tools/packages instead of go/build #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules strike again. The build package doesn't work for pre-compiled packages pulled from an external go module cache, which is stupid. So we have to switch to another library, which is following poor go practices, which is stupid. But meh. At least this works with go module mirrors now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules strike again. The build package doesn't work for pre-compiled packages pulled from an external
go module cache, which is stupid. So we have to switch to another library, which is following poor
go practices, which is stupid.
But meh. At least this works with go module mirrors now.