Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name to basic healing skill learned on S14b #112

Closed
Toranks opened this issue Mar 2, 2023 · 8 comments · Fixed by #117
Closed

Name to basic healing skill learned on S14b #112

Toranks opened this issue Mar 2, 2023 · 8 comments · Fixed by #117
Assignees
@cooljeanius
Labels
enhancement New feature or request
Milestone
1.6.0

Comments

@Toranks
Copy link
Contributor

Toranks commented Mar 2, 2023

Suggestion:

14b_Bontom line 33

id=basic_healing
name= _ "basic healing"
@cooljeanius cooljeanius added the enhancement New feature or request label Mar 2, 2023
@cooljeanius
Copy link
Collaborator

huh I'm surprised we didn't already have that; I'll give it a check once I get up to that scenario...

@cooljeanius cooljeanius self-assigned this Mar 2, 2023
@cooljeanius
Copy link
Collaborator

...it's already got name= _"heals +2, cures poison" on line 35?

@cooljeanius
Copy link
Collaborator

also note that the ability exists in 2 places in the file; there's another copy of it at lines 1000-1009 near the bottom of the file
(I'm actually not quite sure which of the 2 actually gets used...)

@Toranks
Copy link
Contributor Author

Toranks commented Mar 2, 2023 •
edited

Both are used. One is for Gawen and the others for the other non-Akladians units.
What I suggest is to change the name= _"heals +2, cures poison" to a name that doesn't occupy as much in the traits, and move heals+2, cure to description=_"heals +2, cures poison"

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Mar 2, 2023
@cooljeanius
Update 14b_Bontom.cfg
821df8d 
see nemaara/A_New_Order#112
(untested)
@cooljeanius
Copy link
Collaborator

so, like I did in cooljeanius/A_New_Order@821df8d?

@cooljeanius
Copy link
Collaborator

ok so yeah I tested that and it looks fine; I'll include it in my next PR

@cooljeanius cooljeanius mentioned this issue Mar 4, 2023
Merged
@cooljeanius
Copy link
Collaborator

PR #117 ought to close this

cooljeanius added a commit that referenced this issue Mar 7, 2023
@cooljeanius
Merge pull request #117 from cooljeanius/middle_scenarios_tinkering
e439458 
- add @Toranks to the credits
- new portrait for Kyobaine's winter clothing, contributed by OneHourLate, a.k.a. Mells or ohlyf (from Discord, who I also commissioned my last few portraits from)
- I made an attempt at improving the issue #19 situation, but it didn't exactly work out to my liking, so it's hidden behind debug mode for now.
- New debug mode contextual menu option for displaying messages from arbitrary units, for the purposes of testing issue #16 
- Add a macro that I thought I'd included in #109 (and even used there), but looks like I actually forgot... (it's for giving experience to units)
- New scenario! This commit includes S15c, "Raedwood East", which is probably enough to fix issue #72 for now (the scenario still isn't fully complete yet, but it's finished enough for the purposes of closing that issue)
- Mark more units as unrenamable. Closes issue #114 
- Adjust recruitment patterns. Closes issue #116 
- fix #112 
- Something for issue #7 that I thought I'd already submitted in a previous PR (but, actually hadn't)
@cooljeanius
Copy link
Collaborator

Fixed in e439458

@cooljeanius cooljeanius added this to the 1.6.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooljeanius cooljeanius

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Lots of changes! New scenario! New portrait! Bugs fixed! cooljeanius/A_New_Order-1
2 participants
@cooljeanius @Toranks