Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous changes I'd been sitting on #109

Merged
merged 13 commits into from
Mar 1, 2023

Conversation

cooljeanius
Copy link
Collaborator

  • stuff that @Toranks suggested
  • stuff that I thought of just while trying to keep up with him
  • copy over L0 Saurians from "Across The Ocean" and use them in "The Swamp Things" and "Saorduc Swamps"
  • Copy over Rancher from "A Story of the Northlands" and use it in "Outlaw Base"
  • regenerate potfile with wmlxgettext
  • basic leadership animations for units with that ability (precise placement of flare will need further tuning)
    (note that some of this duplicates changes from PR Loyal overlay fixes #103... just some of them, though, not all of them)

- stuff that @Toranks suggested
- stuff that I thought of just while trying to keep up with him
- copy over L0 Saurians from "Across The Ocean" and use them in "The Swamp Things" and "Saorduc Swamps"
- Copy over Rancher from "A Story of the Northlands" and use it in "Outlaw Base"
- regenerate potfile with wmlxgettext
- basic leadership animations for units with that ability (precise placement of flare will need further tuning)
scenarios/08_Outlaw_Base.cfg Outdated Show resolved Hide resolved
scenarios/08_Outlaw_Base.cfg Outdated Show resolved Hide resolved
units/others/Rancher.cfg Outdated Show resolved Hide resolved
cooljeanius and others added 5 commits February 28, 2023 17:21
Co-authored-by: nemaara <nemaara@users.noreply.github.com>
Co-authored-by: nemaara <nemaara@users.noreply.github.com>
Co-authored-by: nemaara <nemaara@users.noreply.github.com>
regenerate with wmlxgettext
@cooljeanius
Copy link
Collaborator Author

actually let's make this a draft; I have some additional things I might want to add...

@cooljeanius cooljeanius marked this pull request as draft February 28, 2023 22:48
- have snowshoes on more difficulties
- make NIGHTMARE a bit harder
- fix duplicated music track
- account for more types of Dunefolk that might possibly become loyal
- there is now a wild boar for Reumario to sacrifice
heal Karen & Ruvio, in case they have been injured
@cooljeanius cooljeanius marked this pull request as ready for review March 1, 2023 00:36
@cooljeanius
Copy link
Collaborator Author

ok, should be good to go again

@cooljeanius cooljeanius requested a review from nemaara March 1, 2023 00:36
scenarios/10_Siege_of_Haeltin.cfg Outdated Show resolved Hide resolved
scenarios/10_Siege_of_Haeltin.cfg Outdated Show resolved Hide resolved
scenarios/10_Siege_of_Haeltin.cfg Show resolved Hide resolved
scenarios/10_Siege_of_Haeltin.cfg Outdated Show resolved Hide resolved
scenarios/10_Siege_of_Haeltin.cfg Outdated Show resolved Hide resolved
scenarios/10_Siege_of_Haeltin.cfg Show resolved Hide resolved
cooljeanius and others added 5 commits February 28, 2023 22:58
Co-authored-by: nemaara <nemaara@users.noreply.github.com>
Co-authored-by: nemaara <nemaara@users.noreply.github.com>
Co-authored-by: nemaara <nemaara@users.noreply.github.com>
minor copyediting of description of Akladian speech patterns
Co-authored-by: nemaara <nemaara@users.noreply.github.com>
@cooljeanius
Copy link
Collaborator Author

cooljeanius commented Mar 1, 2023

@nemaara should I squash this before merging, or...?

@nemaara
Copy link
Owner

nemaara commented Mar 1, 2023

I can do it.

@nemaara nemaara merged commit b0f6ab0 into nemaara:master Mar 1, 2023
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this pull request Mar 2, 2023
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this pull request Mar 2, 2023
@cooljeanius cooljeanius deleted the misc_Toranks_feedback_2 branch March 2, 2023 06:51
cooljeanius added a commit that referenced this pull request Mar 7, 2023
- add @Toranks to the credits
- new portrait for Kyobaine's winter clothing, contributed by OneHourLate, a.k.a. Mells or ohlyf (from Discord, who I also commissioned my last few portraits from)
- I made an attempt at improving the issue #19 situation, but it didn't exactly work out to my liking, so it's hidden behind debug mode for now.
- New debug mode contextual menu option for displaying messages from arbitrary units, for the purposes of testing issue #16 
- Add a macro that I thought I'd included in #109 (and even used there), but looks like I actually forgot... (it's for giving experience to units)
- New scenario! This commit includes S15c, "Raedwood East", which is probably enough to fix issue #72 for now (the scenario still isn't fully complete yet, but it's finished enough for the purposes of closing that issue)
- Mark more units as unrenamable. Closes issue #114 
- Adjust recruitment patterns. Closes issue #116 
- fix #112 
- Something for issue #7 that I thought I'd already submitted in a previous PR (but, actually hadn't)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants