Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Unexpected Guests" minor nits #31

Closed
2 tasks done
cooljeanius opened this issue Oct 12, 2021 · 3 comments · Fixed by #43
Closed
2 tasks done

"Unexpected Guests" minor nits #31

cooljeanius opened this issue Oct 12, 2021 · 3 comments · Fixed by #43
Labels
enhancement New feature or request
Milestone
1.4.1

Comments

@cooljeanius
Copy link
Collaborator

cooljeanius commented Oct 12, 2021 •
edited

  • Battle music should only play once the player has discovered the orcs; before that it should be calmer and more mysterious
  • Clear fog to show orcs speaking
@cooljeanius
Copy link
Collaborator Author

having clemmece/qlvorbis#4 fixed would make the first checkbox easier

cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Dec 11, 2021
@cooljeanius
Update 05_Unexpected_Guests.cfg
f4ff81f 
addresses nemaara/A_New_Order#31
@cooljeanius
Copy link
Collaborator Author

cooljeanius/A_New_Order@f4ff81f fixes both these checkboxes, so we just need to get PR #36 merged so I can open a new PR that contains the fixing commit

cooljeanius referenced this issue in cooljeanius/A_New_Order-1 Mar 25, 2022
@cooljeanius
additional work porting to BfW 1.16
c8087e8 
This ought to be equivalent to cooljeanius/A_New_Order@43565fe..44013a3
Bugs addressed, in order of the commits in my repo addressing them:
Addresses #16 (doesn't fix it entirely, though)
Closes #30
Closes #18
Closes #15
Closes #31
Closes cooljeanius/A_New_Order#12
Doesn't actually do anything about #24, despite adding a comment referring to it
Closes #39
Doesn't really do anything about #19, despite adding comments referring to it
@cooljeanius cooljeanius mentioned this issue Mar 25, 2022
Merged
@cooljeanius
Copy link
Collaborator Author

cooljeanius/A_New_Order@f4ff81f fixes both these checkboxes, so we just need to get PR #36 merged so I can open a new PR that contains the fixing commit

ok #43 is the new PR in question

@cooljeanius cooljeanius added the enhancement New feature or request label May 29, 2022
@cooljeanius cooljeanius added this to the 1.4.1 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

additional work porting to BfW 1.16 cooljeanius/A_New_Order-1
1 participant
@cooljeanius