Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Akladian name generation to new context-free grammar name generator #67

Closed
cooljeanius opened this issue May 31, 2022 · 4 comments
Closed

Move Akladian name generation to new context-free grammar name generator #67

cooljeanius opened this issue May 31, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
1.6.0

Comments

@cooljeanius
Copy link
Collaborator

Kind of a follow-up to #51; screenshot of where I asked about it on Discord:
Screen Shot 2022-05-31 at 18 36 19
@cooljeanius cooljeanius added the enhancement New feature or request label May 31, 2022
@cooljeanius
Copy link
Collaborator Author

According to szopen the rules for Akladian names are basically:

  • sound right (sonorous and melodious) when read phonetically in Polish
  • consonants should make the names look exotic

@cooljeanius cooljeanius added the help wanted Extra attention is needed label Aug 16, 2022
cooljeanius added a commit to cooljeanius/A_New_Order that referenced this issue Feb 18, 2023
@cooljeanius
Update units/_main.cfg
6a4d252 
meant to address nemaara/A_New_Order#67
@cooljeanius
Copy link
Collaborator Author

I've been working on this; I ran into an issue in cooljeanius/A_New_Order@4fa53e3 when trying to add support for last names, though...

@cooljeanius
Copy link
Collaborator Author

I've been working on this; I ran into an issue in cooljeanius/A_New_Order@4fa53e3 when trying to add support for last names, though...

Actually never mind; last names seem to work fine in-game; it's just in Dugi's online generator where they break...

@cooljeanius cooljeanius mentioned this issue Feb 26, 2023
Merged
@cooljeanius
Copy link
Collaborator Author

PR #102 will close this.

cooljeanius added a commit that referenced this issue Feb 27, 2023
@cooljeanius
Merge pull request #102 from cooljeanius/cfg_akladian_names
d93fa57 
This adds a context-free grammar for Akladian names, as I remember @knyghtmare requesting previously.
Closes issue #67.
@cooljeanius cooljeanius added this to the 1.6.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@cooljeanius