Fixed string type codegen.

nemccarthy · Jun 11, 2015 · 77c64bd · 77c64bd
1 parent ffedb62
commit 77c64bd
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
@@ -254,12 +254,12 @@ abstract class BinaryComparison extends BinaryExpression with Predicate {
       case dt: NumericType if ctx.isNativeType(dt) => defineCodeGen (ctx, ev, {
         (c1, c3) => s"$c1 $symbol $c3"
       })
-      case DateType | TimestampType => defineCodeGen (ctx, ev, {
-        (c1, c3) => s"$c1 $symbol $c3"
-      })
-      case other => defineCodeGen (ctx, ev, {
-        (c1, c2) => s"$c1.compare($c2) $symbol 0"
-      })
+      case StringType =>
+        defineCodeGen (ctx, ev, (c1, c2) => s"$c1.compareTo($c2) $symbol 0")
+      case DateType | TimestampType =>
+        defineCodeGen (ctx, ev, (c1, c3) => s"$c1 $symbol $c3")
+      case _ =>
+        defineCodeGen (ctx, ev, (c1, c2) => s"$c1.compare($c2) $symbol 0")
     }
   }