Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a workflow node execution times out, the workflow instance is not marked as stopped or in error #1305

Closed
dcoraboeuf opened this issue Jun 20, 2024 · 1 comment
Closed

If a workflow node execution times out, the workflow instance is not marked as stopped or in error #1305

dcoraboeuf opened this issue Jun 20, 2024 · 1 comment
Labels
extension:workflow status:released Issue released and available type: bug Defect issue
Milestone
4.8

Comments

@dcoraboeuf
Copy link
Contributor

dcoraboeuf commented Jun 20, 2024 •
edited
Loading

Given a workflow like:

name: Test
nodes:
  - id: jenkins
    executorId: jenkins
    data:
      channel: jenkins
      channelConfig:
        config: ...
        job: ...
        callMode: SYNC
        timeout: 1800
  # ...

If the jenkins node execution times out, the corresponding notification record is correctly registered as having timeout and marked as error.

However, the workflow itself remains in Running state and the jenkins node execution as Started.

Upon a failure, mark he node as failed and dequeue all nodes.

Have a button in the workflow to stop a workflow.
@dcoraboeuf dcoraboeuf added this to the 4.8 milestone Jun 20, 2024
@dcoraboeuf dcoraboeuf added the status:wip Issue being currently worked on label Jun 20, 2024
dcoraboeuf added a commit that referenced this issue Jun 20, 2024
@dcoraboeuf
#1305 Stopping workflows in case of error
930eb94
dcoraboeuf added a commit that referenced this issue Jun 20, 2024
@dcoraboeuf
#1305 Stopping workflows in case of timeout
e13b7c4
dcoraboeuf added a commit that referenced this issue Jun 20, 2024
@dcoraboeuf
#1305 Stopping workflow with a mutation
59958bd
dcoraboeuf added a commit that referenced this issue Jun 20, 2024
@dcoraboeuf
#1305 Stopping a workflow in the UI
1cf5aca
@dcoraboeuf dcoraboeuf added status:ready Issue merged in release branch, not released yet status:wip Issue being currently worked on and removed status:wip Issue being currently worked on status:ready Issue merged in release branch, not released yet labels Jun 20, 2024
dcoraboeuf added a commit that referenced this issue Jun 20, 2024
@dcoraboeuf
#1305 Stopping a workflow
d3ddadd
@dcoraboeuf dcoraboeuf added status:released Issue released and available and removed status:wip Issue being currently worked on labels Jun 20, 2024
@dcoraboeuf
Copy link
Contributor Author

Available in 4.8.78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension:workflow status:released Issue released and available type: bug Defect issue
Projects
None yet
Milestone
4.8
Development

No branches or pull requests
1 participant
@dcoraboeuf