Break linkability on client-side after planned migration

(See bug quinn-rs#1803 for the server-side case.)
nemethf · Apr 4, 2024 · 23cc3e3 · 23cc3e3
1 parent ff487f0
commit 23cc3e3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/quinn-proto/src/connection/mod.rs b/quinn-proto/src/connection/mod.rs
@@ -2910,7 +2910,7 @@ impl Connection {
     }
 
     /// Switch to a previously unused remote connection ID, if possible
-    fn update_rem_cid(&mut self) {
+    pub fn update_rem_cid(&mut self) {
         let (reset_token, retired) = match self.rem_cids.next() {
             Some(x) => x,
             None => return,

diff --git a/quinn/src/connection.rs b/quinn/src/connection.rs
@@ -915,7 +915,8 @@ impl State {
     ) -> Result<(), ConnectionError> {
         loop {
             match self.conn_events.poll_recv(cx) {
-                Poll::Ready(Some(ConnectionEvent::Ping)) => {
+                Poll::Ready(Some(ConnectionEvent::LocalAddressChanged)) => {
+                    self.inner.update_rem_cid();
                     self.inner.ping();
                 }
                 Poll::Ready(Some(ConnectionEvent::Proto(event))) => {

diff --git a/quinn/src/endpoint.rs b/quinn/src/endpoint.rs
@@ -221,7 +221,7 @@ impl Endpoint {
         // Generate some activity so peers notice the rebind
         for sender in inner.connections.senders.values() {
             // Ignoring errors from dropped connections
-            let _ = sender.send(ConnectionEvent::Ping);
+            let _ = sender.send(ConnectionEvent::LocalAddressChanged);
         }
 
         Ok(())

diff --git a/quinn/src/lib.rs b/quinn/src/lib.rs
@@ -96,8 +96,8 @@ enum ConnectionEvent {
         error_code: VarInt,
         reason: bytes::Bytes,
     },
+    LocalAddressChanged,
     Proto(proto::ConnectionEvent),
-    Ping,
 }
 
 #[derive(Debug)]