Fix build of plugin and tests with custom target suffix #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This went unnoticed because of a previously installed libconnman-qt4. Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
This went unnoticed because of a previously installed libconnman-qt4. Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
Allows parallel installation with tests enabled. Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
The option is actually called 'notests'. Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
|
LGTM |
lpotter
added a commit
that referenced
this pull request
Mar 30, 2014
Fix build of plugin and tests with custom target suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous pull request I introduced a TARGET_SUFFIX variable, but missed adjusting the plugin and tests subdirectories. This happened, because
1.) in my native test builds, libconnman-qt4 was already installed on the system, therefore hiding the linker issue.
2.) in OpenEmbedded cross-builds, the options notests and noplugin were set.
These issues don't appear if TARGET_SUFFIX is either unset or set to one of qt4 or qt5.