Allow ffmemless effects to be categorized as touch screen related #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 22, 2013 13:22
To be able to follow touch vibration level setting in other plugins, add it to the profile values that get tracked. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
Changed "not enabled" to "disabled" in debug print, looks much more comprehensible. Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
Added new configuration option for effects that allow them to be classified as touch screen related. For touch screen related effects the touchscreen.vibrate.level is followed to determine if the effect should be played or not. The option can be enabled in ffmemless configuration file by adding a "_TOUCH" postfixed configuration line. E.g. one could define NGF_SHORT to be a touch screen related effect by adding to the .ini file: NGF_SHORT_TOUCH = 1 Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
| } | ||
|
|
||
| data = g_hash_table_lookup(ffm.effects, key); | ||
| if (data->touch_effect && n_value_get_int(touch_level) == 0) { |
There was a problem hiding this comment.
can n_value_get_int handle NULL?
There was a problem hiding this comment.
not 100% sure, the code is:
return (value && value->type == N_VALUE_TYPE_INT) ? value->value.i : 0;
I guess the first if(value && ...) fails, that should stop there and skip the pointer access, so it should work (and return 0) :)
There was a problem hiding this comment.
That being said, I actually bumped into this, as the profile plugin was not tracking the vibrate.level thing. So then it will not vibrate as the value goes to 0.. not sure should we actually then allow the playback. That actually might be better that way.
|
LGTM |
kjokinie
pushed a commit
that referenced
this pull request
Oct 22, 2013
Allow ffmemless effects to be categorized as touch screen related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If event is marked as a touch screen related, the touchscreen.vibrate.level is checked from current profile to see if we should play the effect or not. Makes it possible to make touchscreen effects also via ngfd (so that they are profile aware).