Qt5 porting #1
Merged
Qt5 porting #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,5 +4,5 @@ Version=1.0 | |||
| Type=Application | |||
| Terminal=false | |||
| Name=Maps | |||
| Exec=/usr/bin/invoker --single-instance -r 5 --type=d --splash /usr/share/pixmaps/meego-handset-maps-splash-p-800x480.png /usr/bin/meego-handset-maps | |||
| Exec=/usr/bin/invoker --single-instance -r 5 --type=qtcomponents-qt5 --splash /usr/share/pixmaps/meego-handset-maps-splash-p-800x480.png /usr/bin/meego-handset-maps -platform wayland | |||
There was a problem hiding this comment.
As @special commented on qmlcalendar, the app needs to be boostable to take full advantage of qtcomponents-qt5 here. Ex: nemomobile/qmlcalendar@a67cc6a
There was a problem hiding this comment.
See discussion: nemomobile/qmlcalendar#6 (comment)
There was a problem hiding this comment.
Ok will add boostable support
|
Many thanks! |
|
can you please add a prefix in [] to your commit messages? each release needs at least one commit message with such a 'tag' to be able to get through our release processes so e.g: "[maps] Port to Qt 5" |
|
Added prefixes. |
| @@ -1,3 +1,6 @@ | |||
| * Sun Aug 11 2013 Aleksi Suomalainen <suomalainen.aleksi@gmail.com> - 0.1.8 | |||
There was a problem hiding this comment.
drop the changes to .changes, not needed (as mentioned in another PR)
|
great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in Nemo Wayland VM. Works ok except for error messages:
Error message: Qt Location requires app_id and token parameters.
Please register at https://api.developer.nokia.com/ to get your personal application credentials.