[port] Port to QtQuick2/Qt5 #6
Conversation
| Name=Calendar | ||
| Exec=/usr/bin/single-instance /opt/qmlcalendar/bin/qmlcalendar | ||
| Categories=Applications; | ||
| Exec=invoker --type=qtcomponents-qt5 -s /opt/qmlcalendar/bin/qmlcalendar |
There was a problem hiding this comment.
This is wrong. If you'd like to use the qtcomponents-qt5 booster, you must add PKGCONFIG += qdeclarative5-boostable and the MDeclarativeCache usage in main.cpp. Other projects like qmlcalc should have examples of what to do.
Or, that can be a separate change later and this line can be left unchanged.
There was a problem hiding this comment.
Ok I shall add boostable soon after (even though now the app launches without problems). Would you like me to add boostable commit to this PR?
There was a problem hiding this comment.
If it's ready quickly, sure. Otherwise, a separate PR would be fine.
It will still launch without problems, but it's much slower: first the qtcomponents-qt5 booster is failing to launch, then it falls back to a direct unboosted launch.
There was a problem hiding this comment.
Ok, boosted in the same PR. All tested, works
| Requires: | ||
| - libdeclarative-organizer | ||
| - qt5-qtdeclarative-pim-organizer |
There was a problem hiding this comment.
libdeclarative-organizer is a Qt4 package. It's replaced by qt5-qtdeclarative-pim-organizer, so it should be removed.
|
Looks good to me once those dependencies are fixed. Thanks! |
|
Good to go, cleaned up packaging, still works :) |
No description provided.