-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha filter #4
Alpha filter #4
Conversation
bb608e5
to
e259189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made various fixups, more details in the commit messages. Let me know if those changes look good to you, then will merge!
The problem with just using one step in I would recommend using multiple steps and checking explicitly that It would be nice if there was a way we could have really tight tolerances and be sure that |
Updated the test in the other PR (as it worked better after those changes), see 9decbd0 |
keras_spiking/layers.py
Outdated
---------- | ||
states : `~numpy.ndarray` | ||
Optional state array that can be used to override the values returned by | ||
`.SpikingActivationCell.get_initial_state`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be ``cell.get_initial_state``
or something like that.
The new test looks good. So I'm fine to merge this as-is (with the minor fix to the docstring I mentioned above), and then the test will get fixed when we merge #5. Also, it might be a good idea to double-check the docstrings for the base classes, since I obviously didn't do a great job updating them when I reduced the code redundancy. |
8daec02
to
8f51dc7
Compare
Add Alpha filter implementation