Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras nets #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Keras nets #44

wants to merge 4 commits into from

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented May 10, 2017

Improvements for networks in Keras.

hunse added 4 commits May 10, 2017 12:09
TODO:
- test Conv2d layer Theano code
TODO:
- Subtract out data mean for training (remove scaling too?)
Copy link
Contributor

@Seanny123 Seanny123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a little cleanup, but looks legit. Was this a WIP?

X_train, X_test = preprocess(X_train), preprocess(X_test)

data_mean = np.zeros_like(X_train[0])
# data_mean = X_train.mean(axis=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some leftover comments.

from __future__ import print_function

import os
os.environ['THEANO_FLAGS'] = 'device=gpu,floatX=float32'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Keras is back-end agnostic, are these Theano flags necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because I run my Keras with Theano. I'm not sure what the best way to do this is. Maybe comment it out and let people uncomment it if they're using Theano on a GPU.


n_presentations = 100

if 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this code is never going to be run?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I do when I have optional things, that myself or others might want to play around with.

@hunse
Copy link
Collaborator Author

hunse commented Jun 1, 2017

Two of the commits I still have marked WIP.

@Seanny123
Copy link
Contributor

Oh jeez, I'm sorry for bothering you with a premature review. I only realized afterwards the commits were marked WIP. My bad. :(

@Seanny123 Seanny123 changed the title Keras nets WIP: Keras nets Jun 2, 2017
@Seanny123 Seanny123 changed the title WIP: Keras nets Keras nets Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants